[PATCH] D11079: Remove DataLayout from TargetLoweringObjectFile, redirect to Module

Eric Christopher echristo at gmail.com
Tue Jul 14 21:29:07 PDT 2015


echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.

One small inline request then go for it. We can look at refactors later.

-eric


================
Comment at: lib/CodeGen/AsmPrinter/AsmPrinter.cpp:140
@@ -139,3 +139,3 @@
 const DataLayout &AsmPrinter::getDataLayout() const {
-  return *TM.getDataLayout();
+  return MMI->getModule()->getDataLayout();
 }
----------------
joker.eph wrote:
> echristo wrote:
> > Is this going to have problems when you don't have a module (ala some of the other uses?).
> They never call this method (if they do, they're doomed).
Let's grab an assert for MMI to make it clear if something does manage to call it what happened.


http://reviews.llvm.org/D11079







More information about the llvm-commits mailing list