[PATCH] D11188: [LLD] New ELF implementation

Michael Spencer bigcheesegs at gmail.com
Tue Jul 14 15:15:01 PDT 2015


Bigcheese marked 18 inline comments as done.

================
Comment at: ELF/InputFiles.cpp:137
@@ +136,3 @@
+  }
+  return std::error_code();
+}
----------------
atanasyan wrote:
> Will this function return something else except "success" code?
It will. The intent is for this to be the one place we scan the entire section table, which can find broken files.

================
Comment at: ELF/Symbols.h:166
@@ +165,3 @@
+// the same name, it will ask the Lazy to load a file.
+class Lazy : public SymbolBody {
+public:
----------------
atanasyan wrote:
> I guess it is a COFF equivalent for ELF Weak symbol?
This is for archive files.


http://reviews.llvm.org/D11188







More information about the llvm-commits mailing list