[PATCH] D10715: Switch test-release.sh to build with cmake by default (PR21561)

[Hans Wennborg]

hans added inline comments.

================
Comment at: utils/release/test-release.sh:96
@@ -95,3 +100,1 @@
             ;;
-        -no-64bit | --no-64bit )
-            do_64bit="no"
----------------
rengolin wrote:
> I actually use this option on ARM.
> 
> The problem here is that this script assumes x86_64, and that it builds 32 and 64 binaries. With this option, the script skips the 64-bit version. On ARM, if I don't use this, it will build two identical versions but call them 32-bit and 64-bit, which is just wrong and wastes time.
> 
> I see that you also removes the "Release-64" down there, so I believe that would be fine with me, too.
> On ARM, if I don't use this, it will build two identical versions but call them 32-bit and 64-bit, which is just wrong and wastes time.

It did the same for me on x86: two 64-bit versions. The whole set-up seemed broken, so I removed the "Release-64" flavour below and then there's no need for the '-no-64bit' flag anymore.


http://reviews.llvm.org/D10715