[PATCH] Fix test-release.sh to use DESTDIR

Dan Liew dan at su-root.co.uk
Tue Jul 14 10:24:38 PDT 2015


Hi Hans,

Here is the new version of the patch (and hopefully final) version of
the patch. I'm testing it now but you can probably test it much faster
than I can. Looks good so far.


> If InstallPrefix is always /usr/local, we can just put that in there.

I've removed the InstallPrefix from the script and just hardcoded it.


> I don't think this is necessary. I don't think Clang cares about where
> it's run from, and setting --prefix and DESTDIR differently in
> different phases makes everything more complicated. I think leaving
> --prefix as the default and using DESTDIR in each phase is the right

Okay I've gone back to using DESTDIR for all phases of the build.
``--prefix`` is not set explicitly any more.

Thanks,
Dan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: test_release_use_destdirV5.patch
Type: application/octet-stream
Size: 8775 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150714/5609df86/attachment.obj>


More information about the llvm-commits mailing list