[PATCH] D11167: Avoid passing objects with __declspec(align) members by value (PR24113) - llvm part

Hans Wennborg hans at chromium.org
Tue Jul 14 09:41:19 PDT 2015


hans added a comment.

I've worked around the PR by allocating the IntervalMap in ELF.h on the heap instead, r242157.

I probably won't pursue this patch further right now.


================
Comment at: lib/Target/ARM/AsmParser/ARMAsmParser.cpp:192
@@ -191,3 +191,3 @@
 
-  bool validatetLDMRegList(MCInst Inst, const OperandVector &Operands,
+  bool validatetLDMRegList(const MCInst &Inst, const OperandVector &Operands,
                            unsigned ListNo, bool IsARPop = false);
----------------
rnk wrote:
> The whole ARM asm parser probably didn't meant to pass these by value and can probably be committed as is.
r242160


Repository:
  rL LLVM

http://reviews.llvm.org/D11167







More information about the llvm-commits mailing list