[llvm] r241938 - Fix `llvm-config` to emit the linker flag for the combined shared object built by autoconfig/make instead of the individual components.

[JF Bastien]

Reverted in r242152.

On Tue, Jul 14, 2015 at 8:06 AM, JF Bastien <jfb at google.com> wrote:

> Adding Richard, who authored the patch. It looks like the issue is "svn"
> in the name, RequiredLibs doesn't expect it?
>
> We can simply revert the patch, and fix separately.
>
> On Tue, Jul 14, 2015 at 1:52 AM, Laurent Carlier <lordheavym at gmail.com>
> wrote:
>
>> Le vendredi 10 juillet 2015, 20:24:17 JF Bastien a écrit :
>> > Author: jfb
>> > Date: Fri Jul 10 15:24:17 2015
>> > New Revision: 241938
>> >
>> > URL: http://llvm.org/viewvc/llvm-project?rev=241938&view=rev
>> > Log:
>> > Fix `llvm-config` to emit the linker flag for the combined shared object
>> > built by autoconfig/make instead of the individual components.
>> >
>> > Summary:
>> > This fixes `llvm-config` instead of fixing the makefiles because, AIUI,
>> > LLVM's autoconfig/make build system is on the way out anyway.
>> >
>> > This change only affects builds that use autoconfig/make.
>> >
>> > Reviewers: jfb
>> >
>> > Subscribers: echristo, dschuff, llvm-commits
>> >
>> > Differential Revision: http://reviews.llvm.org/D10716
>> >
>> > Modified:
>> >     llvm/trunk/tools/llvm-config/BuildVariables.inc.in
>> >     llvm/trunk/tools/llvm-config/CMakeLists.txt
>> >     llvm/trunk/tools/llvm-config/Makefile
>> >     llvm/trunk/tools/llvm-config/llvm-config.cpp
>> >
>>
>> Now llvm fail to build for me with following options:
>>   CC=gcc CXX=g++ \
>>   ../llvm/configure \
>>     --prefix=/usr \
>>     --sysconfdir=/etc \
>>     --enable-shared \
>>     --enable-libffi \
>>     --enable-targets=all \
>>     --disable-assertions \
>>     --with-python=/usr/bin/python2 \
>>     --enable-optimized
>>
>>   make REQUIRES_RTTI=1 ENABLE_PIC=1
>>
>> results:
>> llvm[2]: Compiling RegexTest.cpp for Release build
>> llvm[2]: Compiling ScaledNumberTest.cpp for Release build
>> llvm[2]: Compiling SourceMgrTest.cpp for Release build
>> llvm[2]: Compiling SpecialCaseListTest.cpp for Release build
>> llvm[2]: Compiling StreamingMemoryObject.cpp for Release build
>> llvm[2]: Compiling StringPool.cpp for Release build
>> llvm[2]: Compiling SwapByteOrderTest.cpp for Release build
>> llvm[2]: Compiling TargetRegistry.cpp for Release build
>> llvm[2]: Compiling ThreadLocalTest.cpp for Release build
>> llvm[2]: Compiling TimeValueTest.cpp for Release build
>> llvm[2]: Compiling UnicodeTest.cpp for Release build
>> llvm[2]: Compiling YAMLIOTest.cpp for Release build
>> llvm[2]: Compiling YAMLParserTest.cpp for Release build
>> llvm[2]: Compiling formatted_raw_ostream_test.cpp for Release build
>> llvm[2]: Compiling raw_ostream_test.cpp for Release build
>> llvm[2]: Compiling raw_pwrite_stream_test.cpp for Release build
>> llvm[2]: Linking Release unit test Support (without symbols)
>> llvm[2]: ======= Finished Linking Release Unit test Support (without
>> symbols)
>> make[2]: Leaving directory '/build/llvm-svn/src/build/unittests/Support'
>> make[1]: Leaving directory '/build/llvm-svn/src/build/unittests'
>> make[1]: Entering directory '/build/llvm-svn/src/build/projects'
>> make[1]: Nothing to be done for 'all'.
>> make[1]: Leaving directory '/build/llvm-svn/src/build/projects'
>> make[1]: Entering directory '/build/llvm-svn/src/build/bindings'
>> make[2]: Entering directory '/build/llvm-svn/src/build/bindings/ocaml'
>> make[3]: Entering directory
>> '/build/llvm-svn/src/build/bindings/ocaml/llvm'
>> make[3]: *** No rule to make target '/build/llvm-
>> svn/src/build/Release/lib/ocaml/libLLVM-3.7.0svn.so', needed by 'build-
>> deplibs'.  Stop.
>> make[3]: *** Waiting for unfinished jobs....
>> llvm[3]: Compiling llvm_ocaml.c for Release build
>> make[3]: Leaving directory '/build/llvm-svn/src/build/bindings/ocaml/llvm'
>> /build/llvm-svn/src/llvm/Makefile.rules:880: recipe for target 'all'
>> failed
>> make[2]: *** [all] Error 1
>> make[2]: Leaving directory '/build/llvm-svn/src/build/bindings/ocaml'
>> /build/llvm-svn/src/llvm/Makefile.rules:939: recipe for target
>> 'ocaml/.makeall' failed
>> make[1]: *** [ocaml/.makeall] Error 2
>> make[1]: Leaving directory '/build/llvm-svn/src/build/bindings'
>> /build/llvm-svn/src/llvm/Makefile.rules:965: recipe for target 'all'
>> failed
>>
>> 241937 was building fine
>> --
>> Laurent Carlier
>> http://www.archlinux.org
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150714/6dc4114d/attachment.html>