[PATCH] D10715: Switch test-release.sh to build with cmake by default (PR21561)

Renato Golin renato.golin at linaro.org
Tue Jul 14 03:34:25 PDT 2015


rengolin added a comment.

About cross compiling, it does work with CMake, but maybe not with this script. Though, people running cross-builds could still use autoconf. Maybe the MIPS release is done in that way? I'm building native on both ARM and AArch64, so that's not a problem for me.


================
Comment at: utils/release/test-release.sh:96
@@ -95,3 +100,1 @@
             ;;
-        -no-64bit | --no-64bit )
-            do_64bit="no"
----------------
I actually use this option on ARM.

The problem here is that this script assumes x86_64, and that it builds 32 and 64 binaries. With this option, the script skips the 64-bit version. On ARM, if I don't use this, it will build two identical versions but call them 32-bit and 64-bit, which is just wrong and wastes time.

I see that you also removes the "Release-64" down there, so I believe that would be fine with me, too.


http://reviews.llvm.org/D10715







More information about the llvm-commits mailing list