[llvm] r241974 - [ExecutionEngine] Add a static cast to the unittest for r241962 to suppress a

David Blaikie dblaikie at gmail.com
Mon Jul 13 16:13:17 PDT 2015


On Fri, Jul 10, 2015 at 7:07 PM, Lang Hames <lhames at gmail.com> wrote:

> Author: lhames
> Date: Fri Jul 10 21:07:28 2015
> New Revision: 241974
>
> URL: http://llvm.org/viewvc/llvm-project?rev=241974&view=rev
> Log:
> [ExecutionEngine] Add a static cast to the unittest for r241962 to
> suppress a
> warning.
>
> Modified:
>     llvm/trunk/unittests/ExecutionEngine/MCJIT/MCJITTest.cpp
>
> Modified: llvm/trunk/unittests/ExecutionEngine/MCJIT/MCJITTest.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/ExecutionEngine/MCJIT/MCJITTest.cpp?rev=241974&r1=241973&r2=241974&view=diff
>
> ==============================================================================
> --- llvm/trunk/unittests/ExecutionEngine/MCJIT/MCJITTest.cpp (original)
> +++ llvm/trunk/unittests/ExecutionEngine/MCJIT/MCJITTest.cpp Fri Jul 10
> 21:07:28 2015
> @@ -258,7 +258,7 @@ TEST_F(MCJITTest, lazy_function_creator_
>
>    // Verify that our handler was called for each unresolved function.
>    auto I = UnresolvedExternals.begin(), E = UnresolvedExternals.end();
> -  EXPECT_EQ(UnresolvedExternals.size(), 2);
> +  EXPECT_EQ(UnresolvedExternals.size(), static_cast<size_t>(2));
>

Could use "2u" instead, if you like. (I think that's how I usually fix this
issue - not sure what's dominant across the LLVM unit tests)


>    EXPECT_FALSE(std::find(I, E, "Foo1") == E);
>    EXPECT_FALSE(std::find(I, E, "Foo2") == E);
>  }
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150713/5ae7ec85/attachment.html>


More information about the llvm-commits mailing list