[PATCH] D11160: Targets: commonize some stack realignment code

Dan Gohman dan433584 at gmail.com
Mon Jul 13 14:37:54 PDT 2015


sunfish accepted this revision.
sunfish added a comment.
This revision is now accepted and ready to land.

This looks good to me. It'd be good to get more eyes on this though.


================
Comment at: lib/CodeGen/TargetRegisterInfo.cpp:313
@@ +312,3 @@
+                              F->hasFnAttribute(Attribute::StackAlignment));
+  return requiresRealignment && canRealignStack(MF);
+}
----------------
I think MIPS' assert makes sense here. If a function "needs" stack realignment, we're going to require that it "can" realign its stack.


http://reviews.llvm.org/D11160







More information about the llvm-commits mailing list