[PATCH] D9751: Add HSAIL target

[Matt Arsenault]

arsenm added inline comments.

================
Comment at: include/llvm/Support/ELF.h:237
@@ -236,1 +236,3 @@
   EM_M32C          = 120, // Renesas M32C series microprocessors
+  EM_HSAIL         = 128, // HSAIL 32bit
+  EM_HSAIL_64      = 129, // HSAIL 64bit
----------------
This is being requested

================
Comment at: lib/Target/HSAIL/HSAILAlwaysInlinePass.cpp:59
@@ +58,3 @@
+  for (Module::iterator I = M.begin(), E = M.end(); I != E; ++I) {
+    Function &F = *I;
+    if (F.hasLocalLinkage() && !F.hasFnAttribute(Attribute::NoInline)) {
----------------
I fixed this in the AMDGPU copy of this pass, so once http://reviews.llvm.org/D11155 is in I'll just remove this file.

================
Comment at: lib/Target/HSAIL/HSAILSection.cpp:16
@@ +15,3 @@
+void HSAILSection::PrintSwitchToSection(const MCAsmInfo &MAI,
+                                        raw_ostream &OS,
+                                        const MCExpr *Subsection) const {
----------------
These sections are created by the generic code in the AsmPrinter. This is exactly what NVPTX does currently to fix this.

================
Comment at: test/CodeGen/HSAIL/128bit-kernel-args.ll:2
@@ +1,3 @@
+; RUN: llc -march=hsail < %s | FileCheck -check-prefix=HSAIL -check-prefix=FUNC %s
+
+; FUNC-LABEL: {{^}}prog function &v4i32_kernel_arg
----------------
People have expressed regret as having a default of CHECK for this before. The idea is someday it might be useful to add an HSAIL64 or something like that someday.


http://reviews.llvm.org/D9751