[PATCH] D9751: Add HSAIL target

[Rafael Ávila de Espíndola]

rafael added inline comments.

================
Comment at: include/llvm/Support/ELF.h:237
@@ -236,1 +236,3 @@
   EM_M32C          = 120, // Renesas M32C series microprocessors
+  EM_HSAIL         = 128, // HSAIL 32bit
+  EM_HSAIL_64      = 129, // HSAIL 64bit
----------------
I don't see these in http://www.sco.com/developers/gabi/latest/ch4.eheader.html.

================
Comment at: lib/Target/HSAIL/CMakeLists.txt:50
@@ +49,3 @@
+#    OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/HSAILCompilationCallback_Win64.obj
+#    MAIN_DEPENDENCY HSAILCompilationCallback_Win64.asm
+#    COMMAND ${CMAKE_ASM_MASM_COMPILER} /Fo ${CMAKE_CURRENT_BINARY_DIR}/HSAILCompilationCallback_Win64.obj /c ${CMAKE_CURRENT_SOURCE_DIR}/HSAILCompilationCallback_Win64.asm
----------------
No commented out code please.

================
Comment at: lib/Target/HSAIL/HSAIL.h:69
@@ +68,3 @@
+
+///
+///
----------------
Empty comments?

================
Comment at: lib/Target/HSAIL/HSAIL.h:103
@@ +102,3 @@
+
+/// createHSAILISelDag - This pass converts a legalized DAG into a
+/// HSAIL-specific DAG, ready for instruction scheduling.
----------------
Don't repeat names in comments.

================
Comment at: lib/Target/HSAIL/HSAILAlwaysInlinePass.cpp:26
@@ +25,3 @@
+
+  static char ID;
+
----------------
please git-clang-format the patch.

================
Comment at: lib/Target/HSAIL/HSAILAlwaysInlinePass.cpp:58
@@ +57,3 @@
+
+  for (Module::iterator I = M.begin(), E = M.end(); I != E; ++I) {
+    Function &F = *I;
----------------
range loop?

================
Comment at: lib/Target/HSAIL/HSAILAsmPrinter.h:33
@@ +32,3 @@
+
+  void EmitFunctionArgument(unsigned ParamIndex, const Argument &Arg,
+                            bool IsKernel, bool IsSExt, raw_ostream &O) const;
----------------
Start functions with lowercase letter when you can (or is this missing an override?)

================
Comment at: lib/Target/HSAIL/HSAILSection.cpp:15
@@ +14,3 @@
+
+void HSAILSection::PrintSwitchToSection(const MCAsmInfo &MAI,
+                                        raw_ostream &OS,
----------------
Just don't create sections instead of having empty section switching.


http://reviews.llvm.org/D9751