[PATCH] D10867: [Codegen] Added intrinsics 'absdiff' and corresponding SDNodes for absolute difference operation

[Shahid]

ashahid added a comment.

Hi Hal,

Thanks for the comments, response Inlined.

Regards,
Shahid


================
Comment at: lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:2699
@@ +2698,3 @@
+/// blend natively.
+SDValue SelectionDAGLegalize::ExpandVSELECT(SDValue Op) {
+  SDLoc DL(Op);
----------------
hfinkel wrote:
> Why are you adding this in this patch?
> 
In absence of this, instruction selection was hitting "LLVM ERROR: Cannot select: vselect".

================
Comment at: lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:2935
@@ +2934,3 @@
+    Results.push_back(Tmp1);
+    break;
+  }
----------------
hfinkel wrote:
> Both ISD::UABSDIFF and ISD::SABSDIFF are the same?
> 
Correct me if I am wrong, I think with respect to expansion here both are same as the signedness of 'absolute diff' operation depends on the 1st 'SUB' operation.


Repository:
  rL LLVM

http://reviews.llvm.org/D10867