[PATCH] D10667: [llvm-stress] Enhance scalar type selection from command line.

hfinkel at anl.gov hfinkel at anl.gov
Thu Jul 9 17:51:15 PDT 2015


hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!

> You can repeat the type on the list and the order is make the difference. Should I stabilize it?


I don't think this is worth worrying about. This is an internal testing tool.


================
Comment at: tools/llvm-stress/llvm-stress.cpp:702
@@ -686,3 +701,3 @@
   // Init LLVM, call llvm_shutdown() on exit, parse args, etc.
-  llvm::PrettyStackTraceProgram X(argc, argv);
+  PrettyStackTraceProgram X(argc, argv);
   cl::ParseCommandLineOptions(argc, argv, "llvm codegen stress-tester\n");
----------------
Not clear why you're removing the llvm:: here in favor of adding 'using namespace llvm;'. I don't have a problem with it, but if it is an independent change, please split it into a separate commit.




http://reviews.llvm.org/D10667







More information about the llvm-commits mailing list