[PATCH] D11054: [ARM] Refactor converting Thumb1 from 3 to 2 operand (nfc)

scott douglass sdouglass at arm.com
Thu Jul 9 06:06:56 PDT 2015


scott-0 added a comment.

Thanks for the review!


================
Comment at: lib/Target/ARM/AsmParser/ARMAsmParser.cpp:5489
@@ +5488,3 @@
+  // then transform to 2 operand version of the same instruction
+  // e.g. 'adds r0, r0, #1' transforms to 'adds r0, #1'
+  if (!(Mnemonic == "add" || Mnemonic == "sub" || Mnemonic == "and" ||
----------------
rengolin wrote:
> This comment should probably be moved down...
Will do.  (I left it here so that more of the this diff was a straight movement of lines.)


http://reviews.llvm.org/D11054







More information about the llvm-commits mailing list