[PATCH] D10961: Disable loop re-rotation for -Oz

hfinkel at anl.gov hfinkel at anl.gov
Wed Jul 8 21:38:17 PDT 2015


hfinkel added a subscriber: hfinkel.

================
Comment at: lib/Transforms/IPO/PassManagerBuilder.cpp:322
@@ -321,3 +321,3 @@
   // rotated form due to GVN or other transformations, and the vectorizer relies
-  // on the rotated form.
-  MPM.add(createLoopRotatePass());
+  // on the rotated form. Disabled at -Oz.
+  MPM.add(createLoopRotatePass(SizeLevel == 2 ? 0 : -1));
----------------
This comment is misleading. The rotation is not disabled at -Oz, it is header duplication that is disabled. The comment above the first invocation says:

  // Rotate Loop - disable header duplication at -Oz

we should be specific here too about what is being disabled.



http://reviews.llvm.org/D10961







More information about the llvm-commits mailing list