[PATCH] D11021: Make TargetTransformInfo keeping a reference to the Module DataLayoutDataLayout is no longer optional. It was initialized with or withouta DataLayout, and the DataLayout when supplied could have been theone from the TargetMachine.

Eric Christopher echristo at gmail.com
Wed Jul 8 15:18:21 PDT 2015


echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.

One inline comment that can be fixed in a follow up patch (preapproved :)

Thanks!

-eric


================
Comment at: lib/Target/AArch64/AArch64TargetTransformInfo.h:53
@@ -52,3 +52,3 @@
   explicit AArch64TTIImpl(const AArch64TargetMachine *TM, Function &F)
-      : BaseT(TM), TM(TM), ST(TM->getSubtargetImpl(F)),
-        TLI(ST->getTargetLowering()) {}
+      : BaseT(TM, F.getParent()->getDataLayout()), TM(TM),
+        ST(TM->getSubtargetImpl(F)), TLI(ST->getTargetLowering()) {}
----------------
The TargetMachine class member is unused.


http://reviews.llvm.org/D11021







More information about the llvm-commits mailing list