[PATCH] D11023: COFF: Emit a symbol table if /debug is specified

[Rui Ueyama]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: COFF/Writer.cpp:324-327
@@ +323,6 @@
+        Strtab.insert(Strtab.end(), Name.begin(), Name.end());
+        Strtab.push_back('\0');
+      } else {
+        memset(Sym.Name.ShortName, 0, COFF::NameSize);
+        memcpy(Sym.Name.ShortName, Name.data(), Name.size());
+      }
----------------
I meant this piece of code is repeated twice in this function. This is more like a personal perference, so if you don't want to make this change, I'm fine with that. I'll try to do this myself.

        ... = Strtab.size() + 4; // +4 for the size field
        Strtab.insert(Strtab.end(), Name.begin(), Name.end());
        Strtab.push_back('\0');


http://reviews.llvm.org/D11023