[PATCH] D11011: Rename llvm.frameescape and llvm.framerecover to localescape and localrecover

Reid Kleckner rnk at google.com
Tue Jul 7 14:43:30 PDT 2015


rnk added reviewers: majnemer, nicholas.
rnk added a subscriber: llvm-commits.

Initially, these intrinsics seemed like part of a family of "frame"
related intrinsics, but now I think that's more confusing than helpful.
Initially, the LangRef specified that this would create a new kind of
allocation that would be allocated at a fixed offset from the frame
pointer (EBP/RBP). We ended up dropping that design, and leaving the
stack frame layout alone.

These intrinsics are really about sharing local stack allocations, not
frame pointers. I intend to go further and add an `llvm.localaddress()`
intrinsic that returns whatever register (EBP, ESI, ESP, RBX) is being
used to address locals, which should not be confused with the frame
pointer.

Naming suggestions at this point are welcome, I'm happy to re-run sed.

http://reviews.llvm.org/D11011

Files:
  docs/ExceptionHandling.rst
  docs/LangRef.rst
  include/llvm/CodeGen/ISDOpcodes.h
  include/llvm/CodeGen/WinEHFuncInfo.h
  include/llvm/IR/Intrinsics.td
  include/llvm/IR/IntrinsicsX86.td
  include/llvm/MC/MCContext.h
  include/llvm/Target/Target.td
  include/llvm/Target/TargetOpcodes.h
  lib/Analysis/IPA/InlineCost.cpp
  lib/CodeGen/AsmPrinter/AsmPrinter.cpp
  lib/CodeGen/AsmPrinter/WinException.cpp
  lib/CodeGen/DeadMachineInstructionElim.cpp
  lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
  lib/CodeGen/SelectionDAG/SelectionDAGDumper.cpp
  lib/CodeGen/WinEHPrepare.cpp
  lib/IR/Verifier.cpp
  lib/Target/X86/X86ISelDAGToDAG.cpp
  lib/Target/X86/X86ISelLowering.cpp
  lib/Target/X86/X86InstrInfo.td
  lib/Target/X86/X86RegisterInfo.cpp
  lib/Target/X86/X86WinEHState.cpp
  lib/Transforms/Scalar/PlaceSafepoints.cpp
  test/CodeGen/WinEH/cppeh-alloca-sink.ll
  test/CodeGen/WinEH/cppeh-catch-and-throw.ll
  test/CodeGen/WinEH/cppeh-catch-scalar.ll
  test/CodeGen/WinEH/cppeh-catch-unwind.ll
  test/CodeGen/WinEH/cppeh-frame-vars.ll
  test/CodeGen/WinEH/cppeh-inalloca.ll
  test/CodeGen/WinEH/cppeh-min-unwind.ll
  test/CodeGen/WinEH/cppeh-mixed-catch-and-cleanup.ll
  test/CodeGen/WinEH/cppeh-multi-catch.ll
  test/CodeGen/WinEH/cppeh-nested-1.ll
  test/CodeGen/WinEH/cppeh-nested-2.ll
  test/CodeGen/WinEH/cppeh-nested-3.ll
  test/CodeGen/WinEH/cppeh-nested-rethrow.ll
  test/CodeGen/WinEH/cppeh-nonalloca-frame-values.ll
  test/CodeGen/WinEH/cppeh-prepared-catch-reordered.ll
  test/CodeGen/WinEH/cppeh-prepared-catch.ll
  test/CodeGen/WinEH/cppeh-prepared-cleanups.ll
  test/CodeGen/WinEH/cppeh-shared-empty-catch.ll
  test/CodeGen/WinEH/cppeh-similar-catch-blocks.ll
  test/CodeGen/WinEH/cppeh-state-calc-1.ll
  test/CodeGen/WinEH/seh-inlined-finally.ll
  test/CodeGen/WinEH/seh-prepared-basic.ll
  test/CodeGen/WinEH/seh-simple.ll
  test/CodeGen/X86/frameescape.ll
  test/CodeGen/X86/seh-catch-all-win32.ll
  test/Transforms/Inline/frameescape.ll
  test/Transforms/PlaceSafepoints/statepoint-frameescape.ll
  test/Verifier/frameescape.ll
  utils/TableGen/CodeGenTarget.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D11011.29213.patch
Type: text/x-patch
Size: 80557 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150707/0ec6ca28/attachment.bin>


More information about the llvm-commits mailing list