[PATCH] D10982: [lld] COFF: Improve undefined symbol diagnostics.

[Rui Ueyama]

ruiu accepted this revision.

This revision is now accepted and ready to land.

LGTM with nits.


================
Comment at: COFF/SymbolTable.cpp:159
@@ +158,3 @@
+  }
+  if (!Undefs.empty()) {
+    for (Undefined *U : Config->GCRoot)
----------------
Inverse this condition and return early.

================
Comment at: COFF/SymbolTable.cpp:163
@@ +162,3 @@
+        llvm::errs() << "<root>: undefined symbol: " << U->getName() << "\n";
+    for (auto &File : Files)
+      if (!isa<ArchiveFile>(File.get()))
----------------
Use actual type instead of auto.


http://reviews.llvm.org/D10982