[PATCH] D10986: Redirect DataLayout from TargetMachine to Module in CodeGen Prepare

Eric Christopher echristo at gmail.com
Tue Jul 7 10:34:11 PDT 2015


echristo accepted this revision.

This revision is now accepted and ready to land.

One inline comment then LGTM.

Thanks!

-eric


================
Comment at: lib/CodeGen/CodeGenPrepare.cpp:314
@@ -308,1 +313,3 @@
 
+  DL = nullptr;
+
----------------
I think since you've always got a Function here you don't need to explicitly null out the DataLayout member and just set it unconditionally at the beginning of runOnFunction (or if you feel strongly it should probably happen for all of the class members).



Repository:
  rL LLVM

http://reviews.llvm.org/D10986







More information about the llvm-commits mailing list