[PATCH] D10656: LLVM OpenMP CMake Overhaul

[Ed Maste]

> Applying this on top of git commit bb405b5 in a clean source tree, I don't have any problems.


Perhaps git doesn't have the warning on by default and I enabled it in my config; in any case I tagged a couple lines above with an example of the complaints. Note that it's a warning only, the patch still applies.


================
Comment at: runtime/CMakeLists.txt:192
@@ +191,3 @@
+set(LIBOMP_SRC_DIR ${LIBOMP_BASE_DIR}/src)
+set(LIBOMP_TOOLS_DIR ${LIBOMP_BASE_DIR}/tools) 
+set(LIBOMP_INC_DIR ${LIBOMP_SRC_DIR}/include/${LIBOMP_OMP_VERSION})
----------------
EOL whitespace here, for example

================
Comment at: runtime/CMakeLists.txt:242
@@ -379,7 +241,3 @@
 
-#########################
-# Setting directory names
-if(${MIC})
-    set(platform "${real_os}_${LIBOMP_MIC_ARCH}") # e.g., lin_knf, lin_knc
-else()
-    set(platform "${real_os}_${LIBOMP_ARCH}") # e.g., lin_32e, mac_32
+# - stats-gathering enables OpenMP stats where things like the number of 
+# parallel regions, clock ticks spent in particular openmp regions are recorded.
----------------
EOL whitespace here

================
Comment at: runtime/cmake/LibompCheckLinkerFlag.cmake:24
@@ +23,3 @@
+         set(CMAKE_SHARED_LINKER_FLAGS \"${flag}\")
+         add_library(foo SHARED src_to_link.c)") 
+    set(failed_regexes "[Ee]rror;[Uu]nknown;[Ss]kipping;LINK : warning")
----------------
EOL whitespace


Repository:
  rL LLVM

http://reviews.llvm.org/D10656