[PATCH] D10758: [Inliner] Teach LLVM to inline through statepoints.

Pat Gavlin pagavlin at microsoft.com
Thu Jul 2 13:44:58 PDT 2015


pgavlin added a comment.

Looks good aside from the pending `StatepointOffset` refactoring and one small comment.


================
Comment at: lib/Transforms/Utils/InlineFunction.cpp:151
@@ -126,1 +150,3 @@
 
+static bool InlineStatepoint(Statepoint SP, InlineFunctionInfo &IFI,
+                             bool InsertLifetime) {
----------------
I'd still like to see some explanation of why the restrictions are there and if they'll be lifted. Doesn't have to be much--even a simple `// TODO` at the beginning of your existing comment would suffice.


http://reviews.llvm.org/D10758







More information about the llvm-commits mailing list