[PATCH] Use function attribute "trap-func-name" and remove TargetOptions::TrapFuncName

Eric Christopher echristo at gmail.com
Wed Jul 1 22:48:38 PDT 2015


Seems reasonable to me. One small inline request that you can do or not do as you prefer :)

-eric


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:4783-4784
@@ -4782,2 +4782,4 @@
   case Intrinsic::trap: {
-    StringRef TrapFuncName = TM.Options.getTrapFunctionName();
+    const auto &F = *DAG.getMachineFunction().getFunction();
+    auto TrapFuncName =
+        I.getAttributes()
----------------
I realize auto is cool and all, but it seems like a bit of overkill here :)

http://reviews.llvm.org/D10832

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list