[PATCH] [PM/AA] Completely remove the AliasAnalysis::copyValue interface.

Chandler Carruth chandlerc at gmail.com
Wed Jul 1 20:37:15 PDT 2015


No in-tree alias analysis used this facility, and it was not called in
any particularly rigorous way, so it seems unlikely to be correct.

Note that one of the only stateful AA implementations in-tree,
GlobalsModRef is completely broken currently (and any AA passes like it
are equally broken) because Module AA passes are not effectively
invalidated when a function pass that fails to update the AA stack runs.

Ultimately, it doesn't seem like we know how we want to build stateful
AA, and until then trying to support and maintain correctness for an
untested API is essentially impossible. To that end, I'm planning to rip
out all of the update API. It can return if and when we need it and know
how to build it on top of the new pass manager and as part of *tested*
stateful AA implementations in the tree.

http://reviews.llvm.org/D10889

Files:
  include/llvm/Analysis/AliasAnalysis.h
  lib/Analysis/AliasAnalysis.cpp
  lib/Analysis/AliasDebugger.cpp
  lib/Analysis/AliasSetTracker.cpp
  lib/Analysis/IPA/GlobalsModRef.cpp
  lib/Analysis/NoAliasAnalysis.cpp
  lib/Transforms/IPO/ArgumentPromotion.cpp
  lib/Transforms/Scalar/GVN.cpp
  lib/Transforms/Scalar/MergedLoadStoreMotion.cpp
  lib/Transforms/Utils/BasicBlockUtils.cpp
  lib/Transforms/Utils/LoopSimplify.cpp

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D10889.28931.patch
Type: text/x-patch
Size: 7887 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150702/64825f5f/attachment.bin>


More information about the llvm-commits mailing list