[PATCH] [PATCH] [ELF/AArch64] Initial General-dynamic TLS support

[Rui Ueyama]

================
Comment at: lib/ReaderWriter/ELF/AArch64/AArch64RelocationHandler.cpp:438
@@ +437,3 @@
+  write32le(location, result | read32le(location));
+  //return std::error_code();
+}
----------------
Please don't leave code commented out.

================
Comment at: lib/ReaderWriter/ELF/AArch64/AArch64RelocationPass.cpp:99
@@ +98,3 @@
+  ArrayRef<uint8_t> rawContent() const override {
+    return ArrayRef<uint8_t>(AArch64TlsdescGotAtomContent, 16);
+  }
----------------
Use array_lengthof instead of 16.

================
Comment at: lib/ReaderWriter/ELF/AArch64/AArch64RelocationPass.cpp:126
@@ +125,3 @@
+  ArrayRef<uint8_t> rawContent() const override {
+    return ArrayRef<uint8_t>(AArch64PltTlsdescAtomContent, 32);
+  }
----------------
Ditto

http://reviews.llvm.org/D10842

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/