[PATCH] [BitcodeReader] Fix for PR23310: llvm-dis crashes when trying to upgrade an intrinsic.

Filipe Cabecinhas filcab+llvm.phabricator at gmail.com
Wed Jul 1 11:57:20 PDT 2015


REPOSITORY
  rL LLVM

================
Comment at: lib/Bitcode/Reader/BitcodeReader.cpp:4464
@@ -4467,1 +4463,3 @@
+        if (CallInst* CI = dyn_cast<CallInst>(UI))
+          UpgradeIntrinsicCall(CI, I.second);
       }
----------------
Please do the range-loop patch as a separate one (before the switch from vector to DenseMap).

================
Comment at: lib/Bitcode/Reader/BitcodeReader.cpp:4540
@@ -4545,1 +4539,3 @@
+        I.first->replaceAllUsesWith(I.second);
+      I.first->eraseFromParent();
     }
----------------
Do the range-for change separately.

http://reviews.llvm.org/D10877

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list