[PATCH] Extending Vector GetElementPtr - please review

David Greene greened at obbligato.org
Wed Jul 1 10:24:10 PDT 2015


Just a couple inline documentation comments.  Everything else looks good given the comments provided by others.


REPOSITORY
  rL LLVM

================
Comment at: docs/LangRef.rst:6227
@@ +6226,3 @@
+"""""""""""""""""""
+
+The ``getelementptr`` returns a vector of pointers, instead of a single address,
----------------
I think we also need to update the summary syntax at the top of the getelementptr documentation.

================
Comment at: docs/LangRef.rst:6253
@@ +6252,3 @@
+
+     getelementptr  %struct.ST, <4 x %struct.ST*> %s, <8 x i64> %ind1,
+       <4 x i32> <i32 2, i32 2, i32 2, i32 2>,
----------------
I don't understand the <8 x i64> here.  Aren't the vector lengths supposed to agree?  The same issue carries through the example.

http://reviews.llvm.org/D10496

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list