[PATCH] Extending Vector GetElementPtr - please review

[Renato Golin]

In http://reviews.llvm.org/D10496#197665, @delena wrote:

> Please see the start of discussion: http://lists.cs.uiuc.edu/pipermail/llvmdev/2015-March/082921.html
>  And the end agreement: http://lists.cs.uiuc.edu/pipermail/llvmdev/2015-March/082989.html


Ok, I missed that discussion, sorry. I agree it's justifiable.

The patch looks good to me, apart from some small comments. But I'd like Hal to give the final approval.

cheers,
--renato


REPOSITORY
  rL LLVM

================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:2792
@@ -2781,2 +2791,3 @@
 
       // If this is a constant subscript, handle it quickly.
+      const auto *CI = dyn_cast<ConstantInt>(Idx);
----------------
This comment is outdated, needs to be moved down.

================
Comment at: lib/IR/Verifier.cpp:2565
@@ -2567,3 +2564,3 @@
     }
   }
   visitInstruction(GEP);
----------------
I think you should add an extra assert that the scalar types, if any, possibly must be pointers of the same family (int / float), but not necessarily the same width.

http://reviews.llvm.org/D10496

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/