[PATCH] [asan and libcxx] Add missing instrumentation in vector::insert

Eric Fiselier eric at efcs.ca
Tue Jun 30 20:09:54 PDT 2015


Thanks for the patch, it LGTM.


================
Comment at: test/std/containers/sequences/vector/asan.pass.cpp:24
@@ -23,1 +23,3 @@
 
+// This is a Toy iterator that ensures that the vector::insert
+// specialization for non-forward_iterators is taken.
----------------
Could you use `support/test_iterators.h` instead?

https://github.com/llvm-mirror/libcxx/blob/master/test/support/test_iterators.h

http://reviews.llvm.org/D10859

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list