[PATCH] Use function attribute "trap-func-name" and remove TargetOptions::TrapFuncName

Eric Christopher echristo at gmail.com
Tue Jun 30 11:55:08 PDT 2015


Couple of small inline comments.

Thanks!

-eric


================
Comment at: lib/CodeGen/SelectionDAG/FastISel.cpp:1351
@@ -1350,3 +1350,3 @@
 
     // Don't handle Intrinsic::trap if a trap funciton is specified.
     if (F && F->getIntrinsicID() == Intrinsic::trap &&
----------------
Fix the typo in the comment while you're here? ;)

================
Comment at: lib/CodeGen/SelectionDAG/FastISel.cpp:1353
@@ -1352,3 +1352,3 @@
     if (F && F->getIntrinsicID() == Intrinsic::trap &&
-        !TM.Options.getTrapFunctionName().empty())
+        I->getParent()->getParent()->hasFnAttribute("trap-func-name"))
       return false;
----------------
MF->getFunction() :)

http://reviews.llvm.org/D10832

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list