[PATCH] [LAA] Merge memchecks for accesses separated by a constant offset

Adam Nemet anemet at apple.com
Tue Jun 30 10:52:32 PDT 2015


================
Comment at: lib/Analysis/LoopAccessAnalysis.cpp:222
@@ +221,3 @@
+
+    SmallVector<struct CheckingPtrGroup, 2> Groups;
+
----------------
Same no struct here either.

================
Comment at: lib/Analysis/LoopAccessAnalysis.cpp:231
@@ +230,3 @@
+      // which can include this pointer.
+      for (struct CheckingPtrGroup &EI : Groups) {
+        // Don't perform more than a certain amount of comparisons.
----------------
Sorry didn't notice these the first time around:

* no need for struct in C++
* since this is no longer an iterator, we should probably call it Group or G or whatever

http://reviews.llvm.org/D10386

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list