[PATCH] COFF: Do not assign linker-weak symbols to selectany comdat sections.

Rafael EspĂ­ndola rafael.espindola at gmail.com
Tue Jun 30 05:44:39 PDT 2015


2015-06-30 2:36 GMT-04:00 David Majnemer <david.majnemer at gmail.com>:
> @rafael, what do you think?


If I remember correctly, the only reason for using comdats at all with
-function-sections was so that link.exe could gc the sections.

Does that still work with IMAGE_COMDAT_SELECT_NODUPLICATES? If so this
LGTM, otherwise we should probably stop using comdats for
-ffunction-sections.


Cheers,
Rafael



More information about the llvm-commits mailing list