[llvm] r240939 - Remove Elf_Sym_Iter.

Filipe Cabecinhas filcab at gmail.com
Mon Jun 29 21:00:46 PDT 2015


Should we document the rationale somewhere, then?
A "we know this field exists, but doing it this way simplifies stuff and we
don't know of any producer which uses a different value", or something?

  Filipe

On Mon, Jun 29, 2015 at 8:15 PM, Rafael EspĂ­ndola <
rafael.espindola at gmail.com> wrote:

> On 29 June 2015 at 22:22, Sean Silva <chisophugis at gmail.com> wrote:
> >
> >
> > On Mon, Jun 29, 2015 at 12:34 PM, Rafael EspĂ­ndola
> > <rafael.espindola at gmail.com> wrote:
> >>
> >> On 29 June 2015 at 14:57, Michael Spencer <bigcheesegs at gmail.com>
> wrote:
> >> > This change violates the ELF spec. You're ignoring the sh_entsize
> >> > field while iterating over symbols. I'm fine with removing the
> >> > "dynamic" bit and fixing the other APIs.
> >>
> >> How so?
> >>
> >> The spec defines the content of those sections. We should report an
> >> error if sh_entsize is wrong.
> >
> >
> > IIRC you are supposed to be able to set an entsize larger than the actual
> > struct size. Can't find a citation though.
>
> I am pretty sure existing producers don't do that and we are trying to
> build a real linker.
>
> Cheers,
> Rafael
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150629/2f09b020/attachment.html>


More information about the llvm-commits mailing list