[PATCH] Fix for 9807. Avoid over-relaxation of 8-bit immediates in integer arithmetic instructions.

Rafael EspĂ­ndola rafael.espindola at gmail.com
Mon Jun 29 20:16:52 PDT 2015


On 29 June 2015 at 22:25, Sean Silva <chisophugis at gmail.com> wrote:
>
>
> On Mon, Jun 29, 2015 at 3:13 PM, Rafael EspĂ­ndola
> <rafael.espindola at gmail.com> wrote:
>>
>> On 29 June 2015 at 18:09, David Kreitzer <david.l.kreitzer at intel.com>
>> wrote:
>> > Fixed the style issue pointed out by David and a few others with braces,
>> > indentation, and an empty comment line. (Old habits die hard.)
>> >
>> > Rafael, I'm happy to change the 2 new tests to use llvm-objdump instead
>> > of llvm-readobj if you think that is preferred. I just want to point out
>> > that llvm-readobj is used more predominantly in test/MC/ELF:
>> >
>> > bash-4.3$ grep llvm-readobj *.s | wc -l
>> > 120
>> > bash-4.3$ grep llvm-objdump *.s | wc -l
>> > 7
>> >
>>
>> llvm-readobj is perfect for testing the structure of the file
>> (section, symbols, relocations).
>>
>> In this particular case llvm-objdump has the big advantage that it can
>> disassemble and prints one instruction per line.
>
>
> The downside is that it requires X86 target, which I'm not sure if
> test/MC/ELF already has an appropriate lit requirement for.

It does:

cat  MC/ELF/lit.local.cfg
if not 'X86' in config.root.targets:
    config.unsupported = True

Cheers,
Rafael




More information about the llvm-commits mailing list