[PATCH] [LAA] Merge memchecks for accesses separated by a constant offset

[silviu.baranga at arm.com]

Hi Adam,

Thanks! Please see the updated version. It should contain all of the requested changes except one. I've added a comment for that one in the review and further comments in the code to explain it.

Thanks,
Silviu


================
Comment at: lib/Analysis/LoopAccessAnalysis.cpp:235-236
@@ +234,4 @@
+        // reasonable.
+        if (TotalComparisons++ > MemoryCheckMergeThreshold)
+          break;
+
----------------
anemet wrote:
> I think that you also want to break out from the entire loop-nest here.  (I'd probably go with a goto in this case.)
I think it is correct. When we reach the comparisons limit we want to default to creating a new group for each pointer.
Otherwise if we would break from the loop nest we would end up ignoring the pointers that we didn't process.

I've also remembered why I didn't previously fold the increment to TotalComparisons into the if statement. Once we reach the threshold we don't want to increment it further.

http://reviews.llvm.org/D10386

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/