[PATCH] LoopStrengthReduce: Try to pass address space to isLegalAddressingMode

Matt Arsenault Matthew.Arsenault at amd.com
Fri Jun 26 15:25:00 PDT 2015


================
Comment at: lib/Transforms/Scalar/LoopStrengthReduce.cpp:3188
@@ -3152,1 +3187,3 @@
+        std::pair<size_t, int64_t> P = getUse(S, LSRUse::Basic,
+                                              nullptr, ~0u);
         LF.LUIdx = P.first;
----------------
hfinkel wrote:
> I'd rather not end up with code like this. It would be better to define some global constant InvalidAddressSpace (or similar) that is equal to ~0u, and then use that.
Where should this be defined? I'm not sure where would be a good place for it

http://reviews.llvm.org/D10289

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list