[PATCH] AMDGPU/SI: Add hsa code object directives

Tom Stellard thomas.stellard at amd.com
Fri Jun 26 05:53:53 PDT 2015


================
Comment at: lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.cpp:71-72
@@ +70,4 @@
+
+  unsigned NameSZ = 4;
+  StringRef Name = StringRef("AMD", NameSZ);
+
----------------
arsenm wrote:
> You can construct it directly
> StringRef Name("AMD", 4);
I need to emit the NULL byte at the end, and the NULL byte won't be emitted if I construct it directly, because the StringRef will have length of 3.

http://reviews.llvm.org/D10757

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list