[compiler-rt] r240767 - [libsanitizer] Delete the unused GetBinaryName() function.

Alexander Potapenko glider at google.com
Fri Jun 26 02:50:45 PDT 2015


I'm going to submit another patch that adds ReadBinaryNameCached(),
just trying to minimize the diff.

On Fri, Jun 26, 2015 at 12:47 PM, Yury Gribov <y.gribov at samsung.com> wrote:
> On 06/26/2015 12:28 PM, Alexander Potapenko wrote:
>>
>> Author: glider
>> Date: Fri Jun 26 04:28:24 2015
>> New Revision: 240767
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=240767&view=rev
>> Log:
>> [libsanitizer] Delete the unused GetBinaryName() function.
>>
>> Modified:
>>      compiler-rt/trunk/lib/sanitizer_common/sanitizer_common.cc
>>      compiler-rt/trunk/lib/sanitizer_common/sanitizer_common.h
>
>
> Hm, wouldn't it be more beneficial to replace ReadBinaryName with
> GetBinaryName? We'd avoid unnecessary mmaps then.
>
> -Y



-- 
Alexander Potapenko
Software Engineer

Google Germany GmbH
Dienerstraße 12
80331 München




More information about the llvm-commits mailing list