[PATCH] Add a DIModule debug info metadata node to the IR.

David Blaikie dblaikie at gmail.com
Thu Jun 25 14:32:50 PDT 2015


REPOSITORY
  rL LLVM

================
Comment at: include/llvm/IR/DIBuilder.h:585
@@ +584,3 @@
+    /// @param ISysRoot    The clang system root (value of -isysroot).
+    DIModule *createModule(DIScope *Scope, StringRef Name,
+                           StringRef ConfigurationMacros,
----------------
Would it be better to make the contents of the module more opaque/generic? I'm not sure - don't know how authoritative these 4 properties {name, config macros, include path(s?), isysroot} is - if we're likely to later need other things, etc. I mean I know the schema is more forwards-compatible by adding new fields, but equally it's a lot of churn to change the schema now, so if these are just an opaque bundle of things that only have meaning to the frontend anyway, I'm wondering if they should be handled as such.

http://reviews.llvm.org/D9614

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list