[llvm] r183213 - [llvm-symbolizer] Avoid calling slow getSymbolSize for Mach-O files. Assume that symbols with zero size are in fact large enough.

[Alexey Samsonov]

On Thu, Jun 25, 2015 at 8:09 AM, Rafael Espíndola <
rafael.espindola at gmail.com> wrote:

> On 24 June 2015 at 17:01, Alexey Samsonov <vonosmas at gmail.com> wrote:
> >
> > On Wed, Jun 24, 2015 at 1:29 PM, Rafael Espíndola
> > <rafael.espindola at gmail.com> wrote:
> >>
> >> Would it make sense to use object::computeSymbolSizes now?
> >
> >
> > Definitely. llvm-symbolizer has an interesting special case for ELF,
> though:
> > if regular symbol table is missing,
> > we iterate over dynamic symbol table, and call getSymbolSize() for each
> > symbol from there. Do you think we
> > should add smth. like computeDynamicSymbolSizes?
>
> Sure, NP.
>
> r240646.
>

Thanks!


>
> Cheers,
> Rafael
>



-- 
Alexey Samsonov
vonosmas at gmail.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150625/a690ccc2/attachment.html>