[compiler-rt] r239020 - [ASan] Make binary name reader cross-platform.

Yury Gribov y.gribov at samsung.com
Thu Jun 25 05:24:55 PDT 2015

On 06/25/2015 03:02 PM, Alexander Potapenko wrote:
> Hi Yury,
> I suspect this revision had caused
> https://code.google.com/p/chromium/issues/detail?id=502974
> I haven't found out yet what exactly is causing the problem, but I
> don't think it was a great idea to remove the caching logic from
> ReadBinaryName without replacing calls to it with GetBinaryName (if
> I'm understanding correctly the intention behind GetBinaryName)

Hm, yeah, does not look good. The problem is that I wrote original patch 
back in 2014 and it only got approved in June. During that time folks 
have been adding new calls to ReadBinaryName which I failed to track as 
I prepared new versions of patch.


More information about the llvm-commits mailing list