[PATCH] [AArch64][ARM] Match interleaved memory accesses into ldN/stN/vldN/vstN intrinsics.

Renato Golin renato.golin at linaro.org
Wed Jun 24 08:48:42 PDT 2015

Comment at: lib/CodeGen/InterleavedAccessPass.cpp:134
@@ +133,3 @@
+  // Check potential Factors.
+  for (Factor = MIN_FACTOR; Factor <= MAX_FACTOR; Factor++)
+    if (isDeInterleaveMaskOfFactor(Mask, Factor, Index))
HaoLiu wrote:
> rengolin wrote:
> > Checking for all factors "up to" in isDeInterleaveMaskOfFactor() is redundant with this line.
> > 
> > Though, I see that you're using it in other functions that may need that functionality.
> > 
> > Not sure how to split this, but it looks inefficient...
> I merged isDeInterleaveMask() and isDeInterleaveMaskOfFactor() into one function isDeInterleaveMask().
Hum, I'm still seeing isDeInterleaveMaskOfFactor in the latest patch...



More information about the llvm-commits mailing list