[llvm] r238918 - AVX-512: VSHUFPD instruction selection - code improvements

Demikhovsky, Elena elena.demikhovsky at intel.com
Tue Jun 23 23:24:00 PDT 2015

Hi Chandler,
          >>  I re-generated the previously deleted test file test/CodeGen/X86/vector-shuffle-512-v8.ll and put it back into repository.
         > I don't understand why you are continuing to use the other tests though?

 The vector-shuffle-512-v16.ll has only 4 tests. How do I check all other patterns without “other tests”?
>>As far I understand, the vector-shuffle-512-v8.ll does not check correctness of the shuffles, it just checks that noting fails.
> That is pretty clearly not the case. The test is checking for specific instruction sequences on each pattern.

>>And it should be re-generated after each optimization, right?
> Yes, and most specifically the diff should show exactly what the change entailed.
What about vector-shuffle-512-v32.ll? You don’t want to generate 32! permutations, right?

-           Elena
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150624/88e04ca0/attachment.html>

More information about the llvm-commits mailing list