[PATCH] [LLD] COFF: Make link order compatible with MSVC link.exe.

Peter Collingbourne peter at pcc.me.uk
Tue Jun 23 17:17:54 PDT 2015


================
Comment at: COFF/SymbolTable.cpp:290
@@ +289,3 @@
+    if (auto *B = dyn_cast<Lazy>(Sym->Body))
+      addMemberFile(B);
+  }
----------------
ruiu wrote:
> pcc wrote:
> > Sorry, missed this; you need error checking here.
> Feel free to do this yourself. (I could do that but I guess that would be faster.)
Done

================
Comment at: COFF/SymbolTable.cpp:290
@@ +289,3 @@
+    if (auto *B = dyn_cast<Lazy>(Sym->Body))
+      addMemberFile(B);
+  }
----------------
pcc wrote:
> ruiu wrote:
> > pcc wrote:
> > > Sorry, missed this; you need error checking here.
> > Feel free to do this yourself. (I could do that but I guess that would be faster.)
> Done
Done

http://reviews.llvm.org/D10672

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list