[PATCH] [LLD] COFF: Make link order compatible with MSVC link.exe.

Rui Ueyama ruiu at google.com
Tue Jun 23 17:00:16 PDT 2015

Comment at: COFF/SymbolTable.cpp:293
@@ +292,3 @@
+  size_t End = BitcodeFiles.end();
+  if (auto EC = run())
pcc wrote:
> ruiu wrote:
> > pcc wrote:
> > > Huh, does this compile? `BitcodeFiles.end()` is an iterator, right?
> > Ah, sorry, I intended to write auto instead of size_t. (And if we make that change, all tests pass.)
> I don't think it is correct to compare iterators like this because the standard library may invalidate iterators if elements are appended to the vector. Can we make this use `size` as before?
You are correct. Updated the code to use size as before.



More information about the llvm-commits mailing list