[PATCH] Tablegen: Extend target register information by giving the users access to call preserved register mask names.

Ahmed Bougacha ahmed.bougacha at gmail.com
Tue Jun 23 13:25:02 PDT 2015


On Tue, Jun 23, 2015 at 1:01 PM, Duncan P. N. Exon Smith
<dexonsmith at apple.com> wrote:
>
>> On 2015-Jun-23, at 12:55, Ahmed Bougacha <ahmed.bougacha at gmail.com> wrote:
>>
>> REPOSITORY
>>  rL LLVM
>>
>> ================
>> Comment at: include/llvm/Target/TargetRegisterInfo.h:473
>> @@ +472,3 @@
>> +  /// Return all the call-preserved register masks defined for this target.
>> +  virtual ArrayRef<const uint32_t *> getRegMasks() const = 0;
>> +  virtual ArrayRef<const char *> getRegMaskNames() const = 0;
>> ----------------
>> ArrayRef already implies 'const', no?
>
> ArrayRef<T> has a const pointer to T.  In this case that means:
>
>     uint32_t const* const*
>
> ArrayRef only implies the second const.  Or am I missing your point?

Nevermind me, I didn't see the pointer ;)

-Ahmed



More information about the llvm-commits mailing list