[PATCH] Working on reconciling out-of-tree patches to compiler-rt for building for iOS.

Chris Bieneman beanz at apple.com
Tue Jun 23 11:43:13 PDT 2015


================
Comment at: lib/sanitizer_common/sanitizer_platform_limits_posix.cc:344
@@ -340,1 +343,3 @@
+#if !SANITIZER_IOS
   unsigned struct_arpreq_sz = sizeof(struct arpreq);
+#endif
----------------
samsonov wrote:
> beanz wrote:
> > samsonov wrote:
> > > Where do you get this constant from on iOS?
> > These patches are about making it build, not function. Anna will be working on patches to make it function, but that is outside of what I'm able to handle here.
> The changes still need to be reasonable. Please either provide the correct value for `struct_arpreq_sz` on iOS, or remove its declaration from header on iOS.
The value is only ever used on Linux, is there a reason not to move it into the `#if SANITIZER_LINUX` block in the header and source?

http://reviews.llvm.org/D10514

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list