[PATCH] LLVM OpenMP CMake Overhaul

Joerg Sonnenberger joerg at britannica.bec.de
Tue Jun 23 11:24:33 PDT 2015


On Tue, Jun 23, 2015 at 04:30:32PM +0000, Jonathan Peyton wrote:
> 1) Renaming internal variables/macros/functions – everything has
> libomp_ or LIBOMP_ prefixed to it unless maybe if it is a local
> variable/parameter inside a function/macro.

Which reminds me, why do we need or even want something like
LIBOMP_ARCH and co? It is somewhat annoying that configuration flags
exists for something that can be perfectly well handled in the code.
Predefined platform macros exist for a reason.

Joerg




More information about the llvm-commits mailing list