[PATCH] Working on reconciling out-of-tree patches to compiler-rt for building for iOS.

Alexey Samsonov vonosmas at gmail.com
Tue Jun 23 11:01:28 PDT 2015


================
Comment at: lib/sanitizer_common/sanitizer_mac.cc:33
@@ -32,2 +32,3 @@
 
+#if !TARGET_OS_IPHONE
 #include <crt_externs.h>  // for _NSGetEnviron
----------------
Please use `SANITIZER_IOS` instead. It is already defined in sanitizer_platform.h (here and below)

================
Comment at: lib/sanitizer_common/sanitizer_mac.cc:371
@@ +370,3 @@
+  // See <rdar://19552184>.
+# if defined(__IPHONE_8_0) && __IPHONE_OS_VERSION_MAX_ALLOWED >= __IPHONE_8_0
+  *bp = ucontext->uc_mcontext->__ss.__fp;
----------------
Please use indentation in nested #ifs

```
  # if foo
    a = x;
  #  if bar
    b = y;
  #  else
    b = yy;
  #  endif
    c = z;
  # endif
```

http://reviews.llvm.org/D10510

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list