[PATCH] Loop Versioning for LICM

Nema, Ashutosh Ashutosh.Nema at amd.com
Tue Jun 23 10:00:26 PDT 2015


> ================
> Comment at: lib/Transforms/Scalar/LoopVersioningLICM.cpp:502
> @@ +501,3 @@
> +/// 2) Make sure loop body should not have any call instruction.
> +/// 3) Check store instruction execution guarantee.
> +/// 4) Loop body should not have any may throw instruction.
> ----------------
> I don't get where this check is being made. Is the comment out-of-date?
Sorry, these are stale comments. 



-----Original Message-----
From: Charlie Turner [mailto:charlie.turner at arm.com] 
Sent: Tuesday, June 23, 2015 4:39 AM
To: Nema, Ashutosh; anemet at apple.com; hfinkel at anl.gov; listmail at philipreames.com
Cc: charlie.turner at arm.com; javed.absar at arm.com; silviu.baranga at arm.com; llvm-commits at cs.uiuc.edu
Subject: Re: [PATCH] Loop Versioning for LICM

REPOSITORY
  rL LLVM

================
Comment at: lib/Transforms/Scalar/LoopVersioningLICM.cpp:502
@@ +501,3 @@
+/// 2) Make sure loop body should not have any call instruction.
+/// 3) Check store instruction execution guarantee.
+/// 4) Loop body should not have any may throw instruction.
----------------
I don't get where this check is being made. Is the comment out-of-date?

http://reviews.llvm.org/D9151

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list